feat: Get AES IV from input (QoL)#2471
Open
andreasrtv wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added an option to the "AES Decrypt" operation, to get the IV directly from the input. Prepending/appending the IV to the ciphertext is extremely common, and this makes the process of decrypting IV+CT or CT+IV a lot quicker and easier.
I am aware that this is already possible using registers + drop bytes, but due to how regularly this must be done, I felt that it deserved its own dedicated option.
The addition has minimal/no impact on the existing UI, with no changes to the default usage of the operation.
Screenshots
Current method
This is how one would get an appended IV using the current functionality. It is overly verbose, takes a bit of time to setup, and is also non-obvious unless you've explored CyberChef in-depth.
New method
This PR adds a new drop down. The previous example can now quickly be achieved:
More screenshots
Default AES Decrypt:
AES Decrypt with "IV from input" enabled:
AI disclosure
No AI was used.
Test Coverage
Existing tests were updated to account for the new args.
Added tests for: